eth: Refactor updateFilterMapsHeads to Use Timer Instead of time.After #32898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
The
updateFilterMapsHeads()
function ateth/backend.go:511
usestime.After()
inside afor-select
loop. This creates a new timer object on every loop iteration. While Go 1.23+ can garbage collect these timers, this pattern is inefficient and goes against Go best practices for timer usage in loops.Affected Code:
Optimized code: